Skip to content

Conversation

petrochenkov
Copy link
Contributor

@petrochenkov petrochenkov commented Mar 24, 2022

Fixes #94832 (comment)
(I currently have to add this to all my PRs because otherwise nothing builds on my machine.)

@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 24, 2022
@petrochenkov
Copy link
Contributor Author

@bors rollup

@jonhoo
Copy link
Contributor

jonhoo commented Mar 24, 2022

We may need a more comprehensive change to deal with #94983, but I think this is the right thing to do in the short term at least.

@mati865
Copy link
Member

mati865 commented Mar 24, 2022

Yeah statically linking libc++ is tricky because it can use different low level libraires like libc++abi, libsupc++ or libcxxrt and sometimes depending on how it was building requires them to be passed.

@petrochenkov
Copy link
Contributor Author

The change landed as a part of #95255.

@petrochenkov petrochenkov deleted the bsymbolic branch February 22, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants